anomaly / gallagher

The missing toolkit for extending Gallagher Command Centre, featuring a CLI, SQL interface, TUI and a Python idiomatic SDK
https://anomaly.github.io/gallagher/
MIT License
11 stars 2 forks source link

Personal Data Fields being parsed ahead of exposing PDF aliases #44

Closed devraj closed 2 months ago

devraj commented 2 months ago

Major refactor of the way personalDataDefinitions are parsed for the cardholder, refs:

Initially I was going down a path of implementing a cache of the personalDataFields which is unnecessary as the cardholder detail response will always return what we need. Hence it makes sense to parse the personalDataDefinitions (see commit) and then make the top level keys accessible as aliases.