search

anomaly / github-secrets-cli

A command line tool for managing Github project secrets
https://www.npmjs.com/package/@anomalyhq/github-secrets-cli
Apache License 2.0
12 stars 2 forks source link

fix(errors): Update deprecated error handling #5 #8

Closed Nabeelhassan closed 4 years ago

Nabeelhassan commented 4 years ago

Please see if this is the appropriate fix you desired.

brendon1555 commented 4 years ago

Hi @Nabeelhassan, thanks for the pull request. This fixes the issue for one of the error cases. Could you implement this for all error handling?

Nabeelhassan commented 4 years ago

By for all you mean the secret:get command ?

brendon1555 commented 4 years ago

I actually meant across all of the commands. Anywhere within the project that we catch an error.

Nabeelhassan commented 4 years ago

could you please run/review it ? I hope it is up to the mark.

brendon1555 commented 4 years ago

Looks good. Thanks for this. 👍

Nabeelhassan commented 4 years ago

Thank you too. stay blessed.