anonaddy / docker

AnonAddy Docker image
MIT License
519 stars 56 forks source link

addy.io 1.0.8 #260

Closed willbrowningme closed 9 months ago

crazy-max commented 9 months ago

Build on arm doesn't look good :disappointed:: https://github.com/anonaddy/docker/actions/runs/7948027904/job/21697548411?pr=260#step:7:4324

#42 [linux/arm/v7 stage-1 5/6] RUN apk --no-cache add -t build-dependencies     git     nodejs     npm   && node --version   && npm --version   && addgroup -g 1000 anonaddy   && adduser -D -h /var/www/anonaddy -u 1000 -G anonaddy -s /bin/sh -D anonaddy   && addgroup anonaddy mail   && curl -sS https://getcomposer.org/installer | php -- --install-dir=/usr/bin --filename=composer   && git config --global --add safe.directory /var/www/anonaddy   && git init . && git remote add origin "https://github.com/anonaddy/anonaddy.git"   && git fetch --depth 1 origin "v1.0.7" && git checkout -q FETCH_HEAD   && composer install --optimize-autoloader --no-dev --no-interaction --no-ansi --ignore-platform-req=php-64bit   && chown -R anonaddy. /var/www/anonaddy   && npm ci --ignore-scripts   && APP_URL=https://addy-sh.test/ npm run production   && npm prune --production   && chown -R nobody.nogroup /var/www/anonaddy   && apk del build-dependencies   && rm -rf /root/.composer     /root/.config     /root/.npm     /var/www/anonaddy/.git     /var/www/anonaddy/node_modules     /tmp/*
#42 216.6 /var/www/anonaddy/node_modules/rollup/dist/native.js:38
#42 216.6   throw new Error(
#42 216.6         ^
#42 216.6 
#42 216.6 Error: Your current platform "linux" and architecture "arm" combination is not yet supported by the native Rollup build. Please use the WASM build "@rollup/wasm-node" instead.
#42 216.6 
#42 216.6 The following platform-architecture combinations are supported:
#42 216.6 android-arm
#42 216.6 android-arm64
#42 216.6 darwin-arm64
#42 216.6 darwin-x64
#42 216.6 linux-arm
#42 216.6 linux-arm64
#42 216.6 linux-arm64 (musl)
#42 216.6 linux-riscv64
#42 216.6 linux-x64
#42 216.6 linux-x64 (musl)
#42 216.6 win32-arm64
#42 216.6 win32-ia32
#42 216.6 win32-x64
#42 216.6 
#42 216.6 If this is important to you, please consider supporting Rollup to make a native build for your platform and architecture available.
#42 216.6     at Object.<anonymous> (/var/www/anonaddy/node_modules/rollup/dist/native.js:38:8)
#42 216.6     at Module._compile (node:internal/modules/cjs/loader:1356:14)
#42 216.6     at Module._extensions..js (node:internal/modules/cjs/loader:1414:10)
#42 216.6     at Module.load (node:internal/modules/cjs/loader:1197:32)
#42 216.6     at Module._load (node:internal/modules/cjs/loader:1013:12)
#42 216.6     at ModuleWrap.<anonymous> (node:internal/modules/esm/translators:202:29)
#42 216.6     at ModuleJob.run (node:internal/modules/esm/module_job:195:25)
#42 216.6     at async ModuleLoader.import (node:internal/modules/esm/loader:336:24)

It says linux arm is not supported but then it's clearly specified in the supported platforms :man_shrugging:

willbrowningme commented 9 months ago

Hmm, that's strange. Do you think that's why the anonaddybot on https://hub.docker.com/repository/docker/anonaddy/anonaddy/general hasn't built the last tag v1.0.5?

crazy-max commented 9 months ago

Hmm, that's strange. Do you think that's why the anonaddybot on https://hub.docker.com/repository/docker/anonaddy/anonaddy/general hasn't built the last tag v1.0.5?

This is not related but I forgot to push the tag my bad, here you go: https://github.com/anonaddy/docker/releases/tag/1.0.5-r0

willbrowningme commented 9 months ago

Hmm, that's strange. Do you think that's why the anonaddybot on https://hub.docker.com/repository/docker/anonaddy/anonaddy/general hasn't built the last tag v1.0.5?

This is not related but I forgot to push the tag my bad, here you go: https://github.com/anonaddy/docker/releases/tag/1.0.5-r0

Ah yes, I forgot about that too!

crazy-max commented 9 months ago

rollup seems something new since https://github.com/anonaddy/anonaddy/commit/fef0c1b02ca8f6a93f000d09f1ed29e9d45acb7e#diff-053150b640a7ce75eff69d1a22cae7f0f94ad64ce9a855db544dda0929316519R659 (v1.0.7) so linked to dependencies update.

@willbrowningme Do you know what imports https://github.com/anonaddy/anonaddy/blame/31d206ac41523961d1f90b4792f9bc5655e79dfa/package-lock.json#L659-L827? Vite v5 maybe?

crazy-max commented 9 months ago

It says linux arm is not supported but then it's clearly specified in the supported platforms 🤷‍♂️

Ah actually linux-arm is supported but not with musl (alpine) :disappointed:

crazy-max commented 9 months ago

@willbrowningme Seems https://github.com/rollup/rollup/issues/5194#issuecomment-1824156669 would solve the issue. In your case with vite: https://github.com/rollup/rollup/issues/5194#issuecomment-1833271025

willbrowningme commented 9 months ago

@crazy-max great find! I've just updated package.json, do I need to tag a new release to trigger a build?

willbrowningme commented 9 months ago

Shall I close this PR?

crazy-max commented 9 months ago

Shall I close this PR?

not needed, updated your changes to 1.0.8, let's see how it goes :eyes:

willbrowningme commented 9 months ago

Awesome, thanks!