search

anongit / DragonspearUI

Dragonspear UI++, a UI mod for BG:EE
18 stars 7 forks source link

Add translation to brazilian portuguese #2

Closed Felipefpl closed 3 years ago

Felipefpl commented 3 years ago

1st i want to thank the ones who are developing this mod, thank you.

2nd - i'd like to ask to check if all strings are correctly displayed, the words/phrases are usually bigger in portuguese than in english, i believe this is the case with other languages too.

anongit commented 3 years ago

Hi, sorry for the late response.

i'd like to ask to check if all strings are correctly displayed, the words/phrases are usually bigger in portuguese than in english, i believe this is the case with other languages too.

I think it's fine, the phrases have about the same length as the ones in the italian.tra file.

However you changed the english.tra file instead of creating a new file. I can close this pull request and make the necessary changes myself, if you want, and if you don't, you will need to create a new file in the dragonspear_ui++/tra/ folder, for example brazilian.tra, and also add the following lines in dragonspear_ui++/dragonspear_ui++.tp2:

LANGUAGE
       ~Brazilian Portuguese (by Felipefpl)~ ~dragonspear_ui++/tra/brazilian.tra~ ~dragonspear_ui++/tra/brazilian.tra~

This is for the language selection menu that appears during installation, with the changes above it look like this:

Felipefpl commented 3 years ago

hi, i updated everything as you said, i hope it's fine now.

anongit commented 3 years ago

Almost, filenames don't match. In dragonspear_ui++/dragonspear_ui++.tp2 it's dragonspear_ui++/tra/brazilian.tra, but you uploaded dragonspear_ui++/tra/brazilian portuguese.tra, you need to change one or another.

Felipefpl commented 3 years ago

Oops, fixed. :P

anongit commented 3 years ago

Okay, I fixed the last thing and squashed all commits.