search

anongit / mytracks

Automatically exported from code.google.com/p/mytracks
0 stars 0 forks source link

Code review request: Issue 90: timestamp-based default track name #204

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Mercurial clone with changes to be reviewed:

simmonmt-90

Revisions to be pulled from that clone (or "all"):

The change is in rev 7984324fd5

Purpose of code changes on the clone:

Add a preference to allow the user to switch between timestamp-based default 
track names ("2010-11-01 14:01") and track-id-based default track names ("track 
5").  Use the timestamp-based names by default.

When reviewing my code changes, please focus on:

Original issue reported on code.google.com by simmonmt@google.com on 1 Nov 2010 at 6:02

GoogleCodeExporter commented 9 years ago 
Do we really need to keep the old format as an option?

Original comment by rdama...@google.com on 1 Nov 2010 at 6:04

GoogleCodeExporter commented 9 years ago 
It'd certainly be simpler to just switch.  I asked on mytracks and 
mytracks-dev, and received three requests to keep the 'track n' version as an 
option: bartn@google.com, gill.smith@gmail.com, and dhudyma@gmail.com.  Nobody 
objected to having the timestamp be the default -- these three just asked that 
they be able to fall back to 'track n'.

Original comment by simmonmt@google.com on 1 Nov 2010 at 6:13

GoogleCodeExporter commented 9 years ago 
Ok then, reviewing.

Original comment by rdama...@google.com on 1 Nov 2010 at 6:28

GoogleCodeExporter commented 9 years ago

Original comment by simmonmt@google.com on 12 Nov 2010 at 7:19