search

anoniscoding / yorlang

A programming language with yoruba language construct
https://anoniscoding.github.io/yorlang/
MIT License
450 stars 70 forks source link

Yorlang multi-language layout #48

Closed skyusuf15 closed 5 years ago

skyusuf15 commented 5 years ago

Error/Warning feedback: Here is the multi-language layout structure and its usage. I hope this PR helps!

skyusuf15 commented 5 years ago

Please note Travis-ci might fail during npm install because it now expects input (where you choose error/warning language). Like I said earlier, the user should be able to select error/warning feedback language during setup time. @anoniscoding you might want to check the Travis test thank you.

anoniscoding commented 5 years ago

Brilliant implementation @skyusuf15 . Thank you very much for taking some time out to implement this. I'll leave my review soon

anoniscoding commented 5 years ago

Thank you in advance as you consider implementing the changes

skyusuf15 commented 5 years ago

Ok, have done all the fix @anoniscoding, kindly review so that i can proceed. Thank you.

skyusuf15 commented 5 years ago

done.

anoniscoding commented 5 years ago

Bro, well done so far. Last thing, you have conflict in your package-lock.json. Please resolve it so i can merge your PR

skyusuf15 commented 5 years ago

Bro, well done so far. Last thing, you have conflict in your package-lock.json. Please resolve it so i can merge your PR

Normally we shouldn't have package-lock.json on the live repository since it is auto-generated once run npm install

skyusuf15 commented 5 years ago

Bro, well done so far. Last thing, you have conflict in your package-lock.json. Please resolve it so i can merge your PR

Done

anoniscoding commented 5 years ago

Well done @skyusuf15