anonymous-pits / pits

PITS: Variational Pitch Inference for End-to-end Pitch-controllable TTS without External Pitch Predictor
https://anonymous-pits.github.io/pits/
MIT License
275 stars 34 forks source link

No Arg Named axis for torch.cat #8

Open Aloento opened 1 year ago

Aloento commented 1 year ago

https://github.com/anonymous-pits/pits/blob/57ca2ef3778396f0f15cd5f186a30925a5e8795e/models.py#L705

https://pytorch.org/docs/stable/generated/torch.cat.html#:~:text=the%20cat%20dimension.-,dim,-(int%2C

anonymous-pits commented 1 year ago

Hi Alento,

It is true that axis is not written on official docs, but it is working code.

image

I did not notice it, because I brought that part from official avocodo implementation and working well.

I will fix it in next monday.

Aloento commented 1 year ago

for newer torch version

in spectrogram_torch -> torch.stft and mel_spectrogram_torch

RuntimeError: stft requires the return_complex parameter be given for real inputs, and will further require that return_complex=True in a future PyTorch release.

Add return_complex=False or .view_as_real()

But

https://pytorch.org/docs/stable/generated/torch.istft.html#:~:text=datatype%20inputs%20are-,no%20longer%20supported,-.%20Input%20must%20now

So wait

https://github.com/mindslab-ai/phaseaug/issues/8

Aloento commented 1 year ago

for new version of librosa, in mel_processing.py

TypeError: mel() takes 0 positional arguments but 5 were given

rewrite to:

librosa_mel_fn(sr=sampling_rate, n_fft=n_fft, n_mels=num_mels, fmin=fmin, fmax=fmax)

Aloento commented 1 year ago

for newer scipy, in pqmf.py

from scipy.signal.windows import kaiser

anonymous-pits commented 1 year ago

Modifying our current implementation to fit the version released last week is challenging.

For now, if you want to use our implementation, please use a Torch version similar to the one specified in the Dockerfile (around Torch 1.9.0).

Aloento commented 1 year ago

image

It's working with pytorch 2