anonymous2ch / libproxy

Automatically exported from code.google.com/p/libproxy
GNU Lesser General Public License v2.1
0 stars 0 forks source link

"-Dmoduledir" can't set MODULE_INSTALL_DIR #136

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. cmake -Dmoduledir=/usr/testlib
2. make && make install
3. modules are still installed in /usr/libproxy/0.4.4/modules

What is the expected output? What do you see instead?
Modules should be installed into the dir configured by moduledir, as documented 
in INSTALL file.

What version of the product are you using? On what operating system?
0.4.4 on Linux (MeeGo)

Please provide any additional information below.
Check libproxy-0.4.4/libproxy/cmake/modules.cmk, you'll find for non-Win32 
platforms the MODULE_INSTALL_DIR is hardcoded to 
"${CMAKE_INSTALL_PREFIX}/${PROJECT_NAME}/${PROJECT_VERSION}/modules". Please 
use moduledir instead of the hardcoded path.

Original issue reported on code.google.com by elliot...@gmail.com on 24 Aug 2010 at 7:39

GoogleCodeExporter commented 9 years ago
Sorry, we forgot to update the INSTALL file. Here's the list of new variables 
has defined in cmake/paths.cmk from the source directory:

CMAKE_INSTALL_PREFIX: Default to "/usr/local", everything is relative to this 
one.
                      This is equivalent to --prefix in autoconf.
BIN_INSTALL_DIR:      Default to "bin" resulting in /usr/local/bin
LIB_INSTALL_DIR:      Default to "lib${LIB_SUFFIX}"
LIB_SUFFIX:           Default to "", often set to "64" on multilib 64bit system
LIBEXEC_INSTALL_DIR:  Default to "libexec"
INCLUDE_INSTALL_DIR:  Default to "include"
SYSCONF_INSTALL_DIR:  Default to "etc"
SHARE_INSTALL_DIR:    Default to "share"

I hope this will help. I'll keep this bug open until the INSTALL file is fixed, 
again sorry for the inconveniences.

Original comment by nicolas.dufresne@gmail.com on 24 Aug 2010 at 3:53

GoogleCodeExporter commented 9 years ago
Oops, I kind of miss the main point, MODULE_INSTALL_DIR can be set to change 
the place modules are being installed. Be aware that modules API/ABI is not yet 
stable, so you should not mix old modules with new one.

Finally, bumping to latest version (current is 0.4.5) is always recommended.

Original comment by nicolas.dufresne@gmail.com on 24 Aug 2010 at 3:58

GoogleCodeExporter commented 9 years ago
INSTALL file has been updated, will be included soon in 0.4.6 tiny release.

Original comment by nicolas.dufresne@gmail.com on 24 Aug 2010 at 6:25

GoogleCodeExporter commented 9 years ago
Marked fixed.

Original comment by nicolas.dufresne@gmail.com on 24 Aug 2010 at 6:25

GoogleCodeExporter commented 9 years ago
Thanks for the fast fix. The only reason I wanted to change the module dir was 
because the modules were installed into /usr/libproxy by default rather than 
/usr/lib/libproxy in 0.4.4. I see this is fixed in 0.4.5, and I have no need to 
customize the module dir.  :)

Original comment by elliot...@gmail.com on 25 Aug 2010 at 3:22

GoogleCodeExporter commented 9 years ago

Original comment by nicolas.dufresne@gmail.com on 1 Sep 2010 at 7:48