Closed samford closed 5 years ago
Ok, I don't want to be the bully that requires disabling the --locked
flag.
I added it in master, so it will be part of the next release. I haven't begun any of the feature work I had planned for the next version, so there is little point in a new release yet (from a user's point of view). But until then, may I suggest cherry-picking 22db5fc?
Thanks for letting me know!
I agree that there's no need to push out a release just for this. Thanks for your help!
In the process of making changes to formulae in the Homebrew package manager, I noticed that shellharden was one of a handful of Rust binary projects without a
Cargo.lock
file in version control. The Cargo book recommends the following (source):More information about the reasoning can be found in the "Why do binaries have Cargo.lock in version control, but not libraries?" section of the Cargo FAQ.
The
Cargo.lock
file helps package managers to keep builds reproducible, sincecargo install
simply uses the latest dependency versions unless the--locked
flag is added to the command, in which case it will use the versions outlined inCargo.lock
. Without aCargo.lock
file, there's a chance that a dependency update will break the build sometime in the future, which is something I've already encountered with other Rust binary projects.I know shellharden currently doesn't have any dependencies but could you please consider checking
Cargo.lock
into version control? There's a chance that Homebrew might roll out the--locked
flag as a default for building Rust projects from source, so it would be helpful to have theCargo.lock
file available here to avoid errors.