search

anorudes / redux-easy-boilerplate

React redux easy boilerplate
MIT License
632 stars 121 forks source link

remove duplicated head.title tag #93

Closed Ouadie closed 7 years ago

Ouadie commented 7 years ago

@anorudes Is there any specific reason for setting ${head ? head.title.toString() : ''} twice ?

anorudes commented 7 years ago

This is not a dublicate. Head.title for title tag, head.meta for meta tags.

Ouadie commented 7 years ago

@anorudes ${head ? head.title.toString() : ''} is called twice:

${head ? head.title.toString() : ''}
 ${head ? head.meta.toString() : ''}
${bundleCSS}
<link rel="shortcut icon" href="/static/images/favicon.png" type="image/x-icon">
${head ? head.title.toString() : ''}
anorudes commented 7 years ago

Oh, you are right!