anosorae / IRRA

Cross-Modal Implicit Relation Reasoning and Aligning for Text-to-Image Person Retrieval (CVPR 2023)
MIT License
205 stars 27 forks source link

There seems to be a bug at datasets/bases.py#L157. #21

Open zhixhan opened 1 year ago

zhixhan commented 1 year ago

At datasets/bases.py#L157, you directly pass caption_tokens to the function _build_random_masked_tokens_and_labels and caption_tokens has be modified in this function. Thus, the masked captions are also used in the sdm task and id task, which is inconsistent with the clarification in the paper.

anosorae commented 1 year ago

Please see the reponse at #13