search

anotherglitchinthematrix / monochrome

Monochromatic theme collection, for those who seeks.
https://marketplace.visualstudio.com/items?itemName=anotherglitchinthematrix.monochrome
MIT License
160 stars 11 forks source link

Switch away from alpha to rgb #1

Closed tj closed 4 years ago

tj commented 4 years ago

Love this theme! Thanks so much. I noticed that VS Code seems slower on my machine with this theme, unless I'm just crazy (possible), I'd guess it's due to all the colors using alpha. Just opening for now but I'll try to send a PR next week if you're cool with it

tj commented 4 years ago

Actually yeah I just tested a different theme, and these ones are noticeably slower on my 2014 MBP at least

anotherglitchinthematrix commented 4 years ago

I've noticed the very same problem on a mac too, it was a lazy decision to use RGBA back then, but since it's causing this problem I will make the change in a week, this change will also improve the readability of the text especially in the light version. As a workaround, uncommenting the hardware-acceleration line in the ~/.vscode/argv.json file worked for me.

tj commented 4 years ago

@anotherglitchinthematrix awesome! It's a beautiful theme :D

tj commented 4 years ago

hmm yeah so confused, performance still seems messed up, but not always, somehow only for this theme even after re-installing haha. Curious if anyone else sees the same, I'm getting 3 or 4 fps in most files, but switching to a different theme is fine so I'm confused.

I opened https://github.com/microsoft/vscode/issues/98738 which may be related, but I still don't see any reason why one theme would perform worse than another (others are using alpha as well).

anotherglitchinthematrix commented 4 years ago

No idea on what's happening there, I've investigated the issue Microsoft/vscode#98738, on my windows, it crashes when I try to see the layers, but there isn't a problem running smoothly. On a mac, I was lucky enough to see that 1000000x1000000 layer on the render tree. But I'm not sure if it's the reason for the problem since the line of code that gives the dimensions to that layer resides in there for 3+ years.

https://github.com/microsoft/vscode/blob/af3d37848c49e763416cf927dcaf65ff3091cfd7/src/vs/editor/browser/view/viewImpl.ts#L280-L281

tj commented 4 years ago

Yeah I thought at first it was a bug, but that giant layer looked intentional. Does this theme seem fine on your Mac? They're all just RGB[A] so I don't understand how there's such a significant performance difference between themes, I can't see it being something wrong with your theme, but if it's a fundamental VS Code issue that's pretty odd as well haha..

anotherglitchinthematrix commented 4 years ago

I haven't encountered any performance issues after 7fb21e842e83dece68528bae4eb9bf09aa2bce74 on my Catalina. It's really interesting to see a mere config file that contains only color definitions causing this kind of a drastic performance issue. I'll keep an eye on the issue to resolve the problem soon.

tj commented 4 years ago

now it seems fine again haha, I don't know, sorry for the noise man! Let's close, it must be something with my machine. Thanks again for the cool theme