search

anothersmith / node-duckdb

DuckDB NodeJS bindings
MIT License
48 stars 12 forks source link

DRAFT PR: windows support for DuckDb master with minimal modifications #140

Closed antonycourtney closed 2 years ago

antonycourtney commented 2 years ago

This branch is a minimal variant of the WindowsSupport branch, with a few key differences:

  1. The versions of various dependencies and dev-dependencies are kept the same as they are in the node-duckdb master branch.
  2. Fixed an off-by-one error in the BLOB handling code in the changes that bring addon/result_iterator.cc up to date with changes in DuckDb master.
  3. Fixed the string matched for CLOSED_RESULT_ERROR_MESSAGE to determine when a C++ exception from DuckDb should result in throwing a JS exception.
  4. A few minor changes to tests to account for changes in test output when building against DuckDb master.
antonycourtney commented 2 years ago

Ooops! This is a premature submission (though I hope to have something ready to submit soon). Closing PR for now.