anothrNick / github-tag-action

A Github Action to tag a repo on merge.

MIT License

765 stars 379 forks source link

Fix Auto Releases #317

Closed gabriel-stackhouse closed 2 months ago

gabriel-stackhouse commented 5 months ago

Summary of changes

Poking around in this repository, I saw your comment in your main workflow file that auto-release creation was broken. Seeing as I have auto-releases working splendidly for my organization, I figured I'd pass along my config if you were interested in using it.

Feel free to change/tweak/adjust whatever you like here, or to reject it entirely. Completely up to you.

Breaking Changes

How changes have been tested

Ran the workflow on my own forked repo with success:

List any unknowns

N/A

sbe-arg commented 3 months ago

To clarify this we closed as we only release this repo using self action not third party actions.

anothrNick commented 3 months ago

Re-opened as https://github.com/softprops/action-gh-release looks like a better alternative to the archived action we currently use for releases.

sbe-arg commented 3 months ago

If we merge as is it won't trigger a release because we are not updating the entrypoint or dockerfile etc.

I would suggest adding a comment somewhere to force a release at merge.

No further comments from me.

gabriel-stackhouse commented 3 months ago

Rebased on master, removed the placeholder comments, and threw in a comment to entrypoint.sh to trigger the workflow run. Tested working on my own repo.

Let me know if you have any more concerns or questions.

sbe-arg commented 3 months ago

Approved. Not sure why I cannot merge

sbe-arg commented 3 months ago

Assuming @anothrNick you changed my permissions?

anothrNick commented 3 months ago

I haven't changed your permissions. Maybe because I reopened? Not sure

sbe-arg commented 3 months ago

Can @gabriel-stackhouse and or @anothrNick merge this.

gabriel-stackhouse commented 3 months ago

@sbe-arg I don't have write permissions to the repo, so I'm also unable to merge.

@anothrNick?