search

anoved / OctoPrint-EmailNotifier

Receive email notifications when OctoPrint jobs are complete. Currently broken. Please fork and fix!
GNU Affero General Public License v3.0
16 stars 35 forks source link

Specify MIME Type of webcam snapshots int the email #18

Closed oxivanisher closed 7 years ago

oxivanisher commented 8 years ago

What were you doing?

Receiving webcam pictures emails from the OctoPrint-EmailNotifier

What did you expect to happen?

To be able to open the image in K-9 (Android mail client)

What happened instead?

I have to download it first, and can only open it then. This is probably happening also in other email clients.

Branch & Commit or Version of OctoPrint

all AFAIK

Printer model & used firmware incl. version

Not important, but Kossel XL 800

Browser and Version of Browser, Operating System running Browser

Android 6, K-9 Mail (will happen in other situations also)

Screenshot(s) showing the problem:

octoptint_bug

oxivanisher commented 8 years ago

The file itself has the correct MIME type:

$ file --mime-type Downloads/snapshot.jpg 
Downloads/snapshot.jpg: image/jpeg
anoved commented 8 years ago

Thanks for the report. Yeah, this is a known issue. https://github.com/anoved/OctoPrint-EmailNotifier/issues/5

Frankly the intricacies of email formatting (and making the web UI more sophisticated) are a bit outside my area of expertise/interest, so any outside help patching this plugin to be more user friendly is welcome as I am unlikely to find the time to prioritize it myself.