anoved / OctoPrint-EmailNotifier

Receive email notifications when OctoPrint jobs are complete. Currently broken. Please fork and fix!
GNU Affero General Public License v3.0
16 stars 35 forks source link

This stinks.. multiple issues #31

Closed jlautner closed 7 years ago

jlautner commented 7 years ago

My god, these plugins should have reviews on them. I spent 2 hours trying to get this thing working... it looks great, screens shots look great, but if I have to get into putty and install yagmail and keyring and other stuff after digging around to find out why none of it can be found, figure out what virtual profiles are... all this to get a simple email notification? Why use Yagmail, why don't you just use smtplib? Is all this so that passwords are stored securely? Who cares about that, if they have access to your script files from the internet you have bigger problems, having the password accessible by the script wouldn't matter. Why not have a test button, so you can test the setup? Why not have a port number option, for non-standard SMTP ports Why not have TLS option and other standard SMTP settings I need to just make another completely different plugin that works and installs in one step... this one is pretty much useless. I finally got it all setup, and I don't even know if it works; testing from the yagmail shows it is still not working. WOW.

anoved commented 7 years ago

Thank you for your feedback. The answer to most of your questions is that I am a novice hobbyist Python programmer who has not been able to keep up with OctoPrint API changes. I wrote this plugin as a proof-of-concept for my own use and have shared it in hopes it would provide a starting point for others. If you read my responses to other reported issues, you will note that I have openly acknowledged this ability deficit and have repeatedly invited others with more expertise to contribute fixes to the exact problems you have noted. Please do write another completely different plugin that works and installs in one step; I will use it and direct visitors to this page to do so as well.

Lastly, please re-read your report and recognize that your written conduct is unkind. Your technical criticism is valid but your insulting tone is not.

jlautner commented 7 years ago

I'm sorry I didn't mean to take it out on you I have just been hitting roadblock after roadblock and I was hoping something would go smoothly but it's not your fault the plugin looks great probably only needs some minor tweaks to get it going smoothly. Once again I sincerely apologize I can have some time to maybe help out

Get Outlook for Androidhttps://aka.ms/ghei36


From: Jim notifications@github.com Sent: Thursday, April 13, 2017 9:28:24 PM To: anoved/OctoPrint-EmailNotifier Cc: Ray Engelking; Author Subject: Re: [anoved/OctoPrint-EmailNotifier] This stinks.. multiple issues (#31)

Thank you for your feedback. The answer to most of your questions is that I am a novice hobbyist Python programmer who has not been able to keep up with OctoPrint API changes. I wrote this plugin as a proof-of-concept for my own use and have shared it in hopes it would provide a starting point for others. If you read my responses to other reported issues, you will note that I have openly acknowledged this ability deficit and have repeatedly invited others with more expertise to contribute fixes to the exact problems you have noted.

Lastly, please re-read your report and recognize that your written conduct is unkind. Your technical criticism is valid but your insulting tone is not.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/anoved/OctoPrint-EmailNotifier/issues/31#issuecomment-294062839, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AGN_fIfk9Fi1tIQpW9BEntMDsZVhq7l2ks5rvsu4gaJpZM4M8ugB.