Closed simonswine closed 6 years ago
Hey, sorry - I had a long extended holiday travel that I'm still trying to catch up from. I'm good with this and will merge it now.
@toidiu As for admin.conf
, config.rs
is hard-coded to expect the config file that our k8s cluster uses. So yes, it currently expects ca and client-cert info. But if you have a config (supported by kubectl) that is different, I'd love a PR that adds support for it.
more specifically, this snippet should be more tolerant of building a client without cert info if it wasn't in the config - rather than just returning errors.
is looks good to me. also it would be nice to have an example for what should that admin.conf file include. its not obvious since there seems to be a dependency on the ca.perm also??