search

anowell / wkhtmltopdf-rs

High-level Rust bindings for wkhtmltopdf
MIT License
75 stars 12 forks source link

Optional warning callback to PdfConverter #10

Closed leandrosilva closed 3 years ago

leandrosilva commented 3 years ago

First off, thanks for sharing your work on wkhtmltopdf. I really appreciate it.

I added an optional warning callback to PdfConverter in order to get notifications of JavaScript errors that may occur while loading and evaluating a page, which may end up giving signal that the resulting PDF is not as expected.

I'll be glad If you thing it is worth to merge it into your repo.

Cheers.

anowell commented 3 years ago

Thanks. I'll try and test this nad get it merged/published this week (feel free to pester me if I drop the ball)

leandrosilva commented 3 years ago

Hello @anowell - I know free time is like a black swan this days, but if got some any time soon, would you mind to merge this PR? Let me know if I can help with anything. Thanks.

anowell commented 3 years ago

Apologies on letting this fall into a black hole, but it's merged now and published in 0.4.0.