anp / lolbench

tracking performance of rustc-generated binaries over time

https://lolbench.rs

Apache License 2.0

104 stars 12 forks source link

Add benchmarks from clap v2.31.2 #63

Closed kitlith closed 5 years ago

kitlith commented 5 years ago

32

benchmarks taken from https://github.com/clap-rs/clap/tree/v2.31.2/benches

Not quite sure I got everything right, but it all seems to work at this point.

kitlith commented 5 years ago

for instance -- i noticed that the global cargo.lock seemed to change, seemingly modifying the versions of some of the packages that I placed explicit bounds on. I'm worried that this will change the version of the package used for all the other benchmarks.

anp commented 5 years ago

Hi! So sorry it took me this long to review this properly. I agree that the Cargo.lock changes might be slightly worrying, but I'm pretty sure the versions that are changing are from the unpinned version ranges used for the support crates.

I opened https://github.com/anp/lolbench/issues/64 to follow up on this question.