anp / moxie

lightweight platform-agnostic tools for declarative UI
https://moxie.rs
Apache License 2.0
828 stars 27 forks source link

Define state consistency within a revision #223

Open zetanumbers opened 3 years ago

zetanumbers commented 3 years ago

Resolves #222 #220 #215 #197.

codecov[bot] commented 3 years ago

Codecov Report

Merging #223 (cfa7bec) into main (4d14a31) will decrease coverage by 0.54%. The diff coverage is 42.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #223      +/-   ##
==========================================
- Coverage   27.78%   27.24%   -0.55%     
==========================================
  Files          50       50              
  Lines       11886    11729     -157     
  Branches     6634     6564      -70     
==========================================
- Hits         3303     3195     -108     
- Misses       6391     6446      +55     
+ Partials     2192     2088     -104     
Impacted Files Coverage Δ
dom/examples/todo/src/filter.rs 0.00% <ø> (ø)
dom/examples/todo/src/item.rs 23.29% <ø> (+1.04%) :arrow_up:
src/runtime/runloop.rs 68.42% <0.00%> (-4.92%) :arrow_down:
src/runtime/context.rs 37.70% <13.04%> (-18.75%) :arrow_down:
src/runtime/var.rs 24.13% <17.64%> (-23.49%) :arrow_down:
src/runtime.rs 23.67% <45.45%> (-0.77%) :arrow_down:
src/lib.rs 38.98% <80.00%> (-1.26%) :arrow_down:
mox/src/lib.rs 0.00% <0.00%> (-40.00%) :arrow_down:
benches/core.rs 75.00% <0.00%> (-15.00%) :arrow_down:
dom/examples/ssr/src/main.rs 28.81% <0.00%> (-8.48%) :arrow_down:
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4d14a31...cfa7bec. Read the comment docs.

anp commented 3 years ago

A question: would this change be easier if RevisionControlState used an AtomicU64 to track the revision number rather than the Revision type itself?