anp / moxie

lightweight platform-agnostic tools for declarative UI
https://moxie.rs
Apache License 2.0
827 stars 27 forks source link

[core] Freshly initialized DepNodes should not propagate their liveness. #266

Closed anp closed 3 years ago

anp commented 3 years ago

Fixes #238.

codecov[bot] commented 3 years ago

Codecov Report

Merging #266 (86204dd) into main (ae44536) will increase coverage by 0.75%. The diff coverage is 99.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #266      +/-   ##
==========================================
+ Coverage   50.60%   51.36%   +0.75%     
==========================================
  Files          48       49       +1     
  Lines        8341     8370      +29     
==========================================
+ Hits         4221     4299      +78     
+ Misses       4120     4071      -49     
Impacted Files Coverage Δ
dyn-cache/src/lib.rs 59.52% <ø> (ø)
dyn-cache/src/definition.rs 92.14% <97.56%> (+0.82%) :arrow_up:
dyn-cache/src/cache_cell.rs 100.00% <100.00%> (ø)
dyn-cache/src/dep_node.rs 93.25% <100.00%> (-0.17%) :arrow_down:
dyn-cache/src/namespace.rs 84.80% <100.00%> (+0.12%) :arrow_up:
tests/issue_238.rs 100.00% <100.00%> (ø)
src/runtime.rs 40.72% <0.00%> (-3.45%) :arrow_down:
ofl/src/server.rs 0.00% <0.00%> (ø)
dom/examples/todo/src/input.rs 27.84% <0.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ae44536...86204dd. Read the comment docs.