Closed anqitong closed 8 years ago
@Thomas-dot-G : can you test it? Only the console area is not implemented yet. You need to fill the fields for Pencil. I'm working on the console area now.
Very nice
For how it works, I would have done something else, because now you can't really add several shapes. When clicking on add, it should just display something in the console (I know that is normal now if it doesn't), but should not open and create the svg image, only the run button should trigger that part
Otherwise, nice !!
Could you add some padding also around the window please
Corrected everything. You CAN add several shapes.
Sometimes, things don't appear on the final display of the image.
Polygon and polyline do not display the points in the xml.
You should disable the fill radio box for lines, polylines and text.
Add a scroll may be on the left, because some times I can't access the add button.
You can also put default value for the pencil of display a warning if the fields are empty.
And the run
button same an image, but we can't click it again, because the image is already created (we can click but nothing will be done).
Run should just show a preview with a random name, maybe in awt, and a button save should save it in xml with a name that the user has to put.
@Thomas-dot-G : I fixed all of that. Please check it and tell if it is okay
An ellipse create a circle (and with the wrong argument it does not show up. Then when you exit the preview page, it also exit the whole GUI, which is quite problematic.
Does not seem so problematic to me, the user does not have to close the AWT window.
See the last commit
Not sure about the last comment, but It's not a problem.
However, it can be a bit problematic, when I wanted to preview my image, then it was in front of the GUI, so I quit it to click on save, and I lost everything, twice^^
It means that if you are doing several tests, to see how it goes, you have to keep all the windows open. I think it is problematic.
It is another windows, so instead of making it exit on close, do hide on close, it will be much better (and short to modify)
The problem is the Code in AWTFrame : System.exit(0); This means it destroys the Java VM so of course it closes my JFrame window too.
Replace it with windowEvent.getWindow().dispose(); it is better that doing the same but with hide();
Conflicts fixed : it was due to the renaming of the packages
Then I am ok
still some conflicts to resolve
Yes
OK to me
62