search

anqitong / LangageDessinVectoriel

1 stars 2 forks source link

19 add drawing language #67

Closed starsasumi closed 8 years ago

starsasumi commented 8 years ago

This is for issue #19

With this language, we can draw things with much simple codes.

anqitong commented 8 years ago

Don't get it. What's your point?

anqitong commented 8 years ago

@starsasumi : problem in the test for #67 :

in the window the polyline is not filled in black
in the svgAndAwt.svg file the polyline is filled in black!
starsasumi commented 8 years ago

@anqitong As the prof required, Painting.java is the "high-level language" that he wants. And codes in our presentations would be the "middle-level language"

anqitong commented 8 years ago

So you're suggesting taht we use directly java in Painting as high-level language?

starsasumi commented 8 years ago

Yes, and the prototype of this Painting is in our discussion in #19

anqitong commented 8 years ago

I think using shape objetcts is already a high-level language.

anqitong commented 8 years ago

I'm not sure it is necessary, but if you really want to use Painting as high-level language, I'm not against it. So I would like to know what @Thomas-dot-G thinks

starsasumi commented 8 years ago

@anqitong I understand, I am also not sure about this. This is why I re-open the issue to ask you two. But I think maybe make it as real RP would be more clear to discuss.

As you can see, codes in Painting are much more clean. And with this, we have a simple-to-use high-level language and also a great GUI, which make our project rocks ;)

anqitong commented 8 years ago

I think you're right about opening a PR to make it clearer!

Thomas-dot-G commented 8 years ago

I don't think this is required, but it can be nice to have a simpler code for the user. However, that should be well documented for M Grall.

starsasumi commented 8 years ago

@Thomas-dot-G If you two agree to merge this, I will rewrite the README.md first ;)

Thomas-dot-G commented 8 years ago

Not yet to merge, but I agree to merge it later (after some modifications)

starsasumi commented 8 years ago

Hey guys, I add tests in TestLanguage.java. Is it better now?

starsasumi commented 8 years ago

I also update README.md. What do you think about it. I will add the insert back later in the Painter API.

anqitong commented 8 years ago

Okay for me

anqitong commented 8 years ago

I will have to add a paragraph descrbing how to use the GUI

starsasumi commented 8 years ago

Is this good to go now?

Thomas-dot-G commented 8 years ago

Except for the Read Me, I am ok to merge. If you remove your changes for the read me and put them in another PR, I think we are ready to merge this.

starsasumi commented 8 years ago

OK