Initial ROS2 Port - Githubissues

anqixu / ueye_cam

A ROS nodelet and node that wraps the driver API for UEye cameras by IDS Imaging Development Systems GMBH.

Other

60 stars 102 forks source link

Initial ROS2 Port #110

Closed stonier closed 3 years ago

stonier commented 3 years ago

Discussion thread in #108.

Replicates the original node functionality:

nodelets -> components
loads ids configurations
loads an intrinsic camera calibration
dynamic parameters

New features:

export ids configurations (via dynamic parameters)

Yet to do (roughly speaking, tickets to spin up here):

Github actions
Binary OSRC build
Complete set of launchers with exemplar ids loads etc
Possible crash problems on horizontal flipping via dynamic parameters

stonier commented 3 years ago

Did you want to squash the commits or leave them modular for easy reference?

stonier commented 3 years ago

@anqixu, @jmackay2 how do you wish to engage on these ros2 contributions? i.e. review required, who clicks on the green button.

I'm thinking that at the very least, the next PR has to be the one that activates github actions and blocks future PRs to this branch on them. Beyond that I'm flexible - I'd prefer if it blocks on reviews, but I understand that we don't have a large pool of reviewers here and you might have time constraints that would slow progress down (in which case I'd hold up the PR only on anything I'd seriously like a second pair of eyes on).

jmackay2 commented 3 years ago

For PRs, I like having review required and a successful build. I think we are fairly responsive to reviews. This big one took me a little longer, so I appreciate your patience with me.

I went ahead and made a Github actions CI for foxy that I originally made a PR for to stonier:ros2. I'll go ahead and merge this PR and redirect the CI PR to anqixu:foxy. After that merges I think we can protect this branch for future PRs.