search

anqixu / ueye_cam

A ROS nodelet and node that wraps the driver API for UEye cameras by IDS Imaging Development Systems GMBH.
Other
60 stars 102 forks source link

Fix galactic errors #119

Closed jmackay2 closed 2 years ago

jmackay2 commented 2 years ago

This fixes a few small ros galactic build errors. These changes were made so that it is backward compatible with foxy.

I think the duration going to nanoseconds is also a little cleaner than the previous method of casting to double and converting to seconds.

nullket commented 2 years ago

I do not use ros2 but those changes look quite good. Do you want me to approve them via the review function or wait for @stonier

jmackay2 commented 2 years ago

I do not use ros2 but those changes look quite good. Do you want me to approve them via the review function or wait for @stonier

You can go ahead and approve them, and I wait a few days in case @stonier has some input before merging.

stonier commented 2 years ago

LGTM