search

anqixu / ueye_cam

A ROS nodelet and node that wraps the driver API for UEye cameras by IDS Imaging Development Systems GMBH.
Other
60 stars 102 forks source link

Fix const warning range for loop #129

Open jmackay2 opened 1 year ago

jmackay2 commented 1 year ago

This fixes the following warning to prevent copying:

error: loop variable 'value' of type 'const std::pair<std::__cxx11::basic_string<char>, int>&' binds to a temporary constructed from type 'const std::pair<const std::__cxx11::basic_string<char>, int>' [-Werror=range-loop-construct] 1873 | for (const std::pair<std::string, INT>& value: COLOR_DICTIONARY) {
jmackay2 commented 1 year ago

Fixes #130

nullket commented 1 year ago

Looks good to me but I am still on noetic so I cannot test it.

SammyRamone commented 3 days ago

It removed this error for me. Thanks @jmackay2 I had to do more changes to get it to work, but I think that this was due to the XS camera that I am using. You can see my fork of this fork here https://github.com/SammyRamone/ueye_cam/tree/xs_cam