search

anqixu / ueye_cam

A ROS nodelet and node that wraps the driver API for UEye cameras by IDS Imaging Development Systems GMBH.
Other
60 stars 102 forks source link

Added change of GPIO mode to be used as trigger. #53

Closed quattrinili closed 3 years ago

quattrinili commented 7 years ago

The included mode for the GPIO pins are Input and Trigger. It is easy to extend it to include other modes but wanted to avoid accidental change of GPIO pins (e.g., as output). Tested on two USB3 IDS 3251LE cameras with a TinyLily as a trigger.

anqixu commented 7 years ago

Changes look good overall. Thanks Alberto! Unfortunately I don't have HW on hand to test.

Q: upon superficial code scan, it seems that both GPIOs will be configured as TRIGGER or INPUT, regardless of whether user wishes to use GPIO or not. Can you please add a 3rd option DISABLE that does not configure the GPIO (e.g. set u32Configuration to IS_GPIO_OUTPUT), for users who wish to use the previous PIN3/PIN4 config?

quattrinili commented 7 years ago

Thanks for already taking a look at it! Previous pin 3/4 config is still usable even if GPIOs are set to Input or Trigger. Indeed actually the default value that is assigned on ueyecockpit in Windows is Input for both GPIOs. But if you want I can add the Output mode as "disable".

sent from my start phone

On Jan 25, 2017 10:30 PM, "Anqi Xu" notifications@github.com wrote:

Changes look good overall. Thanks Alberto! Unfortunately I don't have HW on hand to test.

Q: upon superficial code scan, it seems that both GPIOs will be configured as TRIGGER or INPUT, regardless of whether user wishes to use GPIO or not. Can you please add a 3rd option DISABLE that does not configure the GPIO (e.g. set u32Configuration to IS_GPIO_OUTPUT), for users who wish to use the previous PIN3/PIN4 config?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/anqixu/ueye_cam/pull/53#issuecomment-275300328, or mute the thread https://github.com/notifications/unsubscribe-auth/AE0wRoBOAh1b1nvNmXwGcWgn1ynbwH6yks5rWBNBgaJpZM4LuO5X .

anqixu commented 7 years ago

No I was just guessing OUTPUT as the default. Since you tested that INPUT was the default, please set to that instead.

nullket commented 3 years ago

Based on this PR, I have created a full GPIO stack (Input, Output, PWM, Trigger) with the IDS modes as default. I basically took you PR, extended it on several ends on the newest code base (current master) and added some sanity checks. As this PR is open for quite a long time. I will close it (to clean the repo a little bit) and try to provide this new GPIO functionality as soon as possible.