anrayliu / pyvidplayer2

Reliable, easy, and fast video playing in Python
MIT License
35 stars 10 forks source link

Detect audio output (prefer "pulse") (Fix #35: correct audio device not found on linux). #33

Closed Poikilos closed 2 months ago

Poikilos commented 2 months ago

Tasks:

anrayliu commented 2 months ago

Hey, thanks for the pull request!

Before I merge it, I would like to ask a few questions because I'm too well versed in this.

Firstly, are you on linux? I don't have a linux machine right now and am unable to test pyvidplayer2 there. If so, how was the experience? Did everything work properly?

Second, why did you make a custom logger instead of using the default warnings logger?

And lastly, I'm still confused about the features you've added. Can you explain a little bit more what pulse is?

Again, thanks for your contribution. I would love to collaborate!

Poikilos commented 2 months ago

Ok, I've made an issue to answer the questions so the information is not lost. I added "Fix #35" to the PR name so it will be closed if this is merged. I hope this helps.