ans-4175 / random-gofood

Random GoFood from your unofficial API
random-gofood.vercel.app
Do What The F*ck You Want To Public License
5 stars 1 forks source link

chore(lockfile): fix lockfile changing after installing deps #11

Closed imballinst closed 2 years ago

imballinst commented 2 years ago

I got this in my local:

Switched to branch 'main'
Your branch is up to date with 'origin/main'.
Switched to a new branch 'cleanup-yarnlock'
➜  random-gofood git:(cleanup-yarnlock) yarn
yarn install v1.22.11
[1/4] Resolving packages...
[2/4] Fetching packages...
info fsevents@2.3.2: The platform "linux" is incompatible with this module.
info "fsevents@2.3.2" is an optional dependency and failed compatibility check. Excluding it from installation.
info fsevents@1.2.13: The platform "linux" is incompatible with this module.
info "fsevents@1.2.13" is an optional dependency and failed compatibility check. Excluding it from installation.
[3/4] Linking dependencies...
warning " > react-custom-roulette@1.1.8" has incorrect peer dependency "react@^16.13.1".
warning " > react-custom-roulette@1.1.8" has incorrect peer dependency "react-dom@^16.13.1".
warning "react-custom-roulette > react-scripts > @typescript-eslint/eslint-plugin > tsutils@3.21.0" has unmet peer dependency "typescript@>=2.8.0 || >= 3.2.0-dev || >= 3.3.0-dev || >= 3.4.0-dev || >= 3.5.0-dev || >= 3.6.0-dev || >= 3.6.0-beta || >= 3.7.0-dev || >= 3.7.0-beta".
warning " > react-use-geolocation@0.1.1" has incorrect peer dependency "react@^16.8.0".
warning " > @testing-library/user-event@12.8.3" has unmet peer dependency "@testing-library/dom@>=7.21.4".
[4/4] Building fresh packages...
success Saved lockfile.
Done in 6.87s.
➜  random-gofood git:(cleanup-yarnlock) ✗ git status
On branch cleanup-yarnlock
Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git checkout -- <file>..." to discard changes in working directory)

        modified:   yarn.lock

Please double check -- I think lockfile shouldn't change after a yarn or yarn install, unless the package.json was changed manually. Just to make sure that this isn't machine issue or something.

Signed-off-by: Try Ajitiono ballinst@gmail.com

vercel[bot] commented 2 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/ans4175/random-gofood/D9u9FZozzKPPv5XqTKnk2EWEHb5J
✅ Preview: https://random-gofood-git-fork-imballinst-cleanup-yarnlock-ans4175.vercel.app

ans-4175 commented 2 years ago

I think lockfile shouldn't change

wew, I got some results after I did yarn, theres changed yarn.lock. Hmm, strange. I forgot which step I took.

I'll merge this for updating yarn then, so that it reflected last yarn install in recent/current main HEAD