search

ansasaki / abimap

A helper for library maintainers to use symbol versioning
MIT License
7 stars 1 forks source link

Confusing indentation in __main__ #10

Closed tomato42 closed 6 years ago

tomato42 commented 6 years ago

https://github.com/ansasaki/symbol_version/blob/f441d3446bcb325df9a3ae440313d30da2646952/scripts/symbol_version.py#L1246-L1318

in general, two indentation styles for method parameters are acceptable:

   ret = some_function_with_very_long_name(
       parameter_1, parameter_2, parameter_3,
       parameter_4)

or

   ret = some_function(parameter_1, parameter_2
                       parameter_3, parameter_4)

for calling methods with keyword arguments I'd say the first one is more readable:

   ret = some_function_with_very_long_name(
       test_a=parameter_1,
       very_important='some text parameter')