ansasaki / abimap

A helper for library maintainers to use symbol versioning
MIT License
7 stars 1 forks source link

Improve logged information when --logfile is provided #26

Closed ansasaki closed 6 years ago

ansasaki commented 6 years ago

This adds a better formatter for the logged information when --logfile is provided. It also changes the behaviour of the Single_Logger: a new handler is added every time the Single_Logger factory is called passing a logfile. This may lead to side-effects like doubling the log entries if the same file is passed more than once. Probably it is not the case since the filename is provided only when the new or update command are called.

Fixes #22

codecov-io commented 6 years ago

Codecov Report

Merging #26 into master will increase coverage by 0.47%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #26      +/-   ##
=========================================
+ Coverage   89.42%   89.9%   +0.47%     
=========================================
  Files           2       2              
  Lines         700     703       +3     
  Branches      181     181              
=========================================
+ Hits          626     632       +6     
+ Misses         38      36       -2     
+ Partials       36      35       -1
Impacted Files Coverage Δ
src/symbol_version/symbol_version.py 89.84% <100%> (+0.47%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1c6bff7...9c377bb. Read the comment docs.

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 43


Totals Coverage Status
Change from base Build 40: 0.3%
Covered Lines: 667
Relevant Lines: 703

💛 - Coveralls