search

ansasaki / abimap

A helper for library maintainers to use symbol versioning
MIT License
7 stars 1 forks source link

loggging use without formatter #49

Closed tomato42 closed 6 years ago

tomato42 commented 6 years ago

https://github.com/ansasaki/smap/blob/608f590b98a1ad2e12c078974eafeef8f4aa58fa/src/smap/symver.py#L517-L520

the string is built every time, even if the current logging level won't emit it

using formatting string for warn() will be less computationally expensive:

self.logger.info("%s contains the local '*' wildcard", release.name)