ansasaki / abimap

A helper for library maintainers to use symbol versioning
MIT License
7 stars 1 forks source link

O(n^2) algorithm #55

Closed tomato42 closed 6 years ago

tomato42 commented 6 years ago

https://github.com/ansasaki/smap/blob/608f590b98a1ad2e12c078974eafeef8f4aa58fa/src/smap/symver.py#L1263-L1264

removed = set(removed)
all_symbols = [i for i in all_symbols if i not in removed]

will reduce complexity to O(n * log n)