ansasaki / abimap

A helper for library maintainers to use symbol versioning
MIT License
7 stars 1 forks source link

Fixed bugs in updates with release info #69

Closed ansasaki closed 6 years ago

ansasaki commented 6 years ago

When release information were provided (using "-r"), updates which added symbols but not removed were failing because the element used to point to the release to be modified was obtained in a generator, which ceases to exist in the end of the for loop. Changing the loop to iterate over the actual elements of the releases list solved this bug.

The strings in the result of get_info_from_release_string() were not being converted to upper case. This was leading to errors when searching for releases to be updated when release info is provided.

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 127


Totals Coverage Status
Change from base Build 124: 0.01%
Covered Lines: 730
Relevant Lines: 736

💛 - Coveralls
codecov-io commented 6 years ago

Codecov Report

Merging #69 into master will increase coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #69      +/-   ##
=========================================
+ Coverage   96.59%   96.6%   +<.01%     
=========================================
  Files           4       4              
  Lines         734     736       +2     
  Branches      186     188       +2     
=========================================
+ Hits          709     711       +2     
  Misses          6       6              
  Partials       19      19
Impacted Files Coverage Δ
src/smap/symver.py 96.54% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4927c1c...dbb02b9. Read the comment docs.