search

ansble / monument-cli

The CLI for monument projects
http://monument.ansble.com
2 stars 5 forks source link

Closes #42: Add scanjs rules to eslintrc. #45

Closed matsieftw closed 8 years ago

matsieftw commented 8 years ago

This should resolve issue #42. Added scanjs rules to the project template files. Let me know if I did this incorrectly. I am new to contributing.

matsieftw commented 8 years ago

Thank you for the feedback. Now that you have mentioned updating the _package.json I see why that needed to be updated.

I tried to fix the spacing in eslintrc to match your guidance. I changed the settings in my vimrc to use spaces. Let me know if I need to adjust my settings (and the spacing) further! Thanks for the reply.

designfrontier commented 8 years ago

It also looks like there are a couple files in the generated project that need to be cleaned up with the new rules in place. 

[06:33:24] Using gulpfile ~/projects/monument-cli-test/gulpfile.js
[06:33:24] Starting 'lint'...
[06:33:27] 
app.js
   1:1   error    "use strict" is unnecessary inside of modules  strict

gulpfile.js
  1:1  error  "use strict" is unnecessary inside of modules  strict

routes/error.js
   1:1  error    "use strict" is unnecessary inside of modules  strict

routes/error.test.js
   2:1  error    "use strict" is unnecessary inside of modules   strict

routes/main.js
  1:1  error  "use strict" is unnecessary inside of modules  strict

routes/main.test.js
  2:1  error    "use strict" is unnecessary inside of modules  strict

test_stubs/connectionStub.js
  1:1  error  "use strict" is unnecessary inside of modules  strict
matsieftw commented 8 years ago

Fingers crossed on this attempt.

designfrontier commented 8 years ago

Thanks for an awesome contribution! I'll get the release cut either this afternoon or tomorrow :-)