Code Review #2: Editable HTMX Boxes

anschelburk / simple_planner

Apache License 2.0

0 stars 0 forks source link

Code Review #2: Editable HTMX Boxes #17

Closed anschelburk closed 3 months ago

anschelburk commented 4 months ago

Per the updates I wrote in Issue #3, I continued to develop the code for this feature, but am not sure what to do at this point. I do have one question about new files. I created several new files in this update:

list_item.html
list_item_add.html
list_item_edit.html
forms.py

Are all of them necessary? (This was especially unclear toward the end of this thread, where ChatGPT seemed to reference the add_item_form.html template, but then said it was no longer strictly necessary. Do you know what's going on there?

Looking forward to checking in tomorrow!

bbelderbos commented 4 months ago

@anschelburk was in meetings, lunch now, then I will take a fresh new look ...

bbelderbos commented 4 months ago

good news was that the calendar update part worked on my end this morning ...

anschelburk commented 3 months ago

@anschelburk was in meetings, lunch now, then I will take a fresh new look ...

Sounds good! Looking at it right now. Interesting problem!

bbelderbos commented 3 months ago

I tried from scratch and got something working, please clone this repo in a test dir and check it out: https://github.com/bbelderbos/django-editable-list - have to say this was not easy + intuitive but I hope this helps you ...

bbelderbos commented 3 months ago

@anschelburk was in meetings, lunch now, then I will take a fresh new look ...

Sounds good! Looking at it right now. Interesting problem!

Indeed, this gets into the guts of htmx and web dev!

anschelburk commented 3 months ago

I tried from scratch and got something working, please clone this repo in a test dir and check it out: https://github.com/bbelderbos/django-editable-list - have to say this was not easy + intuitive but I hope this helps you ...

Been looking into this for the past hour and a half. Really taking some time to dive into the code. Really interesting. Will update later today.

anschelburk commented 3 months ago

I tried from scratch and got something working, please clone this repo in a test dir and check it out: https://github.com/bbelderbos/django-editable-list - have to say this was not easy + intuitive but I hope this helps you ...

Been looking into this for the past hour and a half. Really taking some time to dive into the code. Really interesting. Will update later today.

This was so interesting to go through - thank you for putting it together, I learned a lot reading through it and researching the different pieces of the code. Going to integrate the relevant pieces of this project tomorrow morning my time. Will send an update then.