search

anse1 / sqlsmith

A random SQL query generator
GNU General Public License v3.0
744 stars 126 forks source link

Add Redshift support #25

Closed robins closed 3 years ago

robins commented 4 years ago

This pull request is towards adding Redshift support.

In its current state, it fetches all (possible) database objects and generates an SQL in --dry-run mode. There are pending issues such as avoiding some SQL features - LATERAL / TABLESAMPLE etc. (noted in Issues in my fork) but it'd help if this could be considered for merging / review in its present state.

robins commented 4 years ago

As with the other Pull Request around adding privilege checks for Postgres, have added some privilege checks for Redshift (types / column privilege checks weren't available back then, so they can't be done easily).

anse1 commented 3 years ago

I'm still a bit hesitant about this pull request. Currently, I can test
the support for all of the supported products myself before a release
but AFAICT that won't be possible with Redshift without unreasonable
expense/effort.

It also looks like the repository the pull request was made from is gone
by now and I can only look at it in an awkward fashion in the browser.
Are you still interested in getting it merged?

robins commented 3 years ago

This was a while back and regret that I am unable to prioritize this at this time. Would probably come back with a separate request if I am able to focus on this again.

Thanks for taking a look.