search

anseki / plain-draggable

The simple and high performance library to allow HTML/SVG element to be dragged.
https://anseki.github.io/plain-draggable/
MIT License
773 stars 99 forks source link

moved deps out of dev deps #103

Closed superelement closed 2 years ago

superelement commented 2 years ago

I moved the dependencies needed for the module to run out of devDependencies and into dependencies so that it can be imported (using webpack) without the need to npm install from within the node_modules package.

anseki commented 2 years ago

Hi @superelement, thank you for the PR. Those packages should be in devDependencies in accordance with customary practice. https://anseki.github.io/plain-draggable/#development Thank you for your time. :smile:

superelement commented 2 years ago

That's a bit disappointing. It's a great package and I just wanted to import it into my project (like every other npm package) and have it run on pipelines and stuff without having to do extra manual installs. When I tried to use the min version, importing won't work (am I doing something wrong here?), but in any case, the source is generally better for debugging locally. Otherwise you're forcing me to use my forked version... which isn't ideal.

anseki commented 2 years ago

That is specification of NPM (and Node.js). An option that installs devDependencies packages might be supported by future version of NPM.

superelement commented 2 years ago

Ok, I see what you mean. I've created another PR for exporting a separate bundle for easy import. https://github.com/anseki/plain-draggable/pull/104