search

anseki / vscode-color

Helper with GUI to generate color codes such as CSS color notations.
MIT License
97 stars 27 forks source link

Color notations not working with sass indented syntax files #52

Closed raldred closed 7 years ago

raldred commented 7 years ago

Steps to Reproduce:

  1. Open a sass file with colors
  2. Observe no color notation.
  3. Open a scss file with colors
  4. Observe color notation working.

Log (All lines): (Click menu of VS Code "Help > Toggle Developer Tools", and click "Console" tab)

Nothing logged
anseki commented 7 years ago

Hi @raldred, thank you for the report. Sorry, What does the "color notation" mean? Do you mean that e.g. hsl(1, 2, 3) is not selected when you do Pick Color command?

raldred commented 7 years ago

Apologies I should have included a screenshot. Picking a color works fine with hex, rgb and hsl.

It's just there is autocomplete popup & no small indicator box with the current color in.

SCSS (works fine): screenshot 2017-08-10 10 50 05

SASS (nothing): screenshot 2017-08-10 10 45 52

anseki commented 7 years ago

This is "Color Picker" extension that shows a dialog box, and "Convert Color". It seems that you said about "syntax highlight" of VS Code editor. You should report that to Microsoft, not here.

raldred commented 7 years ago

Ohh really, I totally assumed the color indicator inline came with this extension sorry for wasting your time.

anseki commented 7 years ago

😄

ScorpioCoding commented 6 years ago

@raldred I've got the same issue. Did you report the issue to Microsoft ? and do you know which ticket # ?

@anseki Cool extnsion and sorry for clogging your issue tracker, dude...thnx

raldred commented 6 years ago

@ScorpioCoding yes I did, they don't and won't be supporting the indent sass syntax.

anseki commented 6 years ago

Hi @raldred, BTW, Was the https://github.com/anseki/vscode-color/issues/66 solved?

ScorpioCoding commented 6 years ago

@raldred, @anseki I got an email yesterday from the guys at VSCode that they are not responsable for the issue due to the fact that SASS (not scss) is not supported by them. Due to the fact that SASS an external language is. And they advise me to relay the isssue to them. OK, but hoe do I relay the issue to,? Who is them? This is what I call passing the buck around..!!!

anseki commented 6 years ago

Hi @ScorpioCoding,

Who sent the email to you? At least, you should ask that question to one who sent the email (not here) because we don't know that email and its message. Also, I guess that the SASS is (native) supported by future version of VS Code because many requests about SASS were assigned. https://github.com/Microsoft/vscode/labels/css-less-sass

ScorpioCoding commented 6 years ago

@anseki : my bad sorry dude it wasn't an email sorry, me mixing up twee situations... What I meant to say there is an issue at microsoft where they comment that they don't support SASS https://github.com/Microsoft/vscode/issues/36724

anseki commented 6 years ago

I see. 😄 However, @aeschli said that it is supported by extensions. Also, this extension (Color Picker) already supports SASS.

aeschli commented 6 years ago

In order to get color decorators in SASS file, SASS extensions need to provide a colorDecorator. Please file an issue against the SASS extension you use.

anseki commented 6 years ago

Hi @aeschli, thank you for the advice. @ScorpioCoding, in any case, this is a repository of Color Picker extension, you should report an issue about VS Code or an extension to those repositories, not here.

ScorpioCoding commented 6 years ago

@aeschli Sass extension, ok now you've lost me.
I just did a sass -v and got Sass 3.5.5 (Bleeding Edge) How do I determine which Sass extension to file an issue against.?

ScorpioCoding commented 6 years ago

@aeschli Ok this is my sass situation on my Win10 pro

  1. Installed Ruby -> gem install Sass
  2. In VSCode I've got 3 extensionsthat handle Sass
    • Sass from Robin Bently
    • Sass Fromatter from Sasa Jovanovic Spuki
    • Style Formatter from dweber019 (missed one) So to whom do I send the issue to ?? Or Am I better off installing different extensions ?
aeschli commented 6 years ago

@ScorpioCoding That would be Sass from Robin Bently then: https://github.com/robinbentley/vscode-sass-indented/issues

ScorpioCoding commented 6 years ago

@aeschli : OK : Got it thanks, but last couple of questions... And yes I do now this is the wrong place for this but... 1) Am I better of looking for a different extension if yes any suggestions? 2) Why doesn't Microsoft support the real Sass language and only Sassy css?

aeschli commented 6 years ago

@ScorpioCoding Sorry, I'm not a Sass user myself and therefore don't have any tips on which the best extension. Our team has a limited number of developer and we need to focus on the languages we use ourselves. We're very happy that people from the community help us, and also want to encourage external extensions. Let's help them with good feedback!