search

anseki / vscode-color

Helper with GUI to generate color codes such as CSS color notations.
MIT License
97 stars 27 forks source link

Doesn't restore focus in macOS with full screen mode #61

Closed bunchjesse closed 6 years ago

bunchjesse commented 6 years ago

Steps to Reproduce:

  1. Click the green toolbar button to go full screen
  2. Highlight a color and issue the convert command
  3. Select an option

When the command runs, you're booted to another space.

anseki commented 6 years ago

Hi @bunchjesse, thank you for the report.

So, do you mean that a window of VS Code was moved to another space?

bunchjesse commented 6 years ago

No. I simply mean that macOS changes to the desktop space. VS stays full screen but in its own space. I have to swipe or CMD+TAB back to it.

Sent from my iPhone

On Oct 11, 2017, at 23:54, anseki notifications@github.com wrote:

Hi @bunchjesse, thank you for the report.

So, do you mean that a window of VS Code was moved to another space?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

anseki commented 6 years ago

Do you mean that a "focus" is moved? That is, "active window" is switched.

bunchjesse commented 6 years ago

It appears so, yes.

Sent from my iPhone

On Oct 12, 2017, at 07:33, anseki notifications@github.com wrote:

Do you mean that a "focus" is moved? That is, "active window" is switched.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

anseki commented 6 years ago

Thank you for the explanation. I see. I'll try to find the solution but that might not be easy because there is not similar report yet, and it seems that this issue is caused by Electron.

bunchjesse commented 6 years ago

I’m guessing you’re unable to reproduce this? I can provide a video and try to reproduce on a clean install to ensure it isn’t something running on my machine (though I run it quite cleanly).

Sent from my iPhone

On Oct 12, 2017, at 08:22, anseki notifications@github.com wrote:

Thank you for the explanation. I see. I'll try to find the solution but that might not be easy because there is not similar report yet, and it seems that this issue is caused by Electron.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

anseki commented 6 years ago

Thank you for your help. 😄 I'll look for report about this issue with Electron.

BTW, does Pick Color command work without this issue?

bunchjesse commented 6 years ago

Yes, same thing happens when using Pick Color.

anseki commented 6 years ago

Ummm... If you configured colorHelper.resident, try to remove that.

bunchjesse commented 6 years ago

I did not.

Sent from my iPhone

On Oct 13, 2017, at 02:59, anseki notifications@github.com wrote:

Ummm... If you configured colorHelper.resident, try to remove that.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

anseki commented 6 years ago

Then, try the "colorHelper.resident": true.

anseki commented 6 years ago

No reply came. I close this issue.

therebelrobot commented 5 years ago

I'm getting the same issue, neither "colorHelper.resident": true nor false solved the issue.

anseki commented 5 years ago

Hi @therebelrobot, thank you for your report.

I think that this issue is unfortunately not easy because it is caused by behavior of Electron. That gets the focus, then the screen mode is switched.

I will report if I find solution or information. Also, I welcome those. Thank you. :smile: