search

anseki / vscode-color

Helper with GUI to generate color codes such as CSS color notations.
MIT License
97 stars 27 forks source link

Electron pre-built dependency #79

Closed JakeSidSmith closed 5 years ago

JakeSidSmith commented 5 years ago

Just noticed that this extension comes bundled with electron-prebuilt (which is over 100MB), is this necessary? Could it be moved to a dev dependency?

JakeSidSmith commented 5 years ago

Seems that this module is retired: https://github.com/electron-userland/electron-prebuilt

anseki commented 5 years ago

Hi @JakeSidSmith, thank you for the comment. Of course the electron-prebuilt is required, and that can not be moved to the devDependencies because it is a framework, it is not a development tool such as transcompiler. See: https://electronjs.org/

anseki commented 5 years ago

No reply came, then I close this issue.

JakeSidSmith commented 5 years ago

Hey, @anseki, sorry been too busy to really look into this. I was just surprised to see it as a dependency as VSCode runs on electron anyway.

It seems it's not as easy as I'd imagined: https://github.com/Microsoft/vscode/issues/3011

What is electron needed for in this extension?

anseki commented 5 years ago

Hi @JakeSidSmith, thank you for the reply. :smile: The electron is used for GUI. The dialog box that is opened by Pick Color command is electron window.

anseki commented 5 years ago

If your computer does not have enough space, internal color picker is the better choice. VS Code already implemented the internal color picker. To use that, you have to install nothing.

JakeSidSmith commented 5 years ago

Thank you. I had no idea that existed. 🙂