anseki / vscode-color

Helper with GUI to generate color codes such as CSS color notations.
MIT License
97 stars 27 forks source link

Add HSL to color spaces for editing the color #83

Closed seanonthenet closed 5 years ago

seanonthenet commented 5 years ago

Please add ability to change HSB to HSL (or add HSL) to be able to have a lightness slider. Would really help selecting shades in the same color.

anseki commented 5 years ago

Hi @Spark3000, thank you for your comment. The Color Picker for VS Code already can change the color notations for the output. You can specify that by drop-down list in the dialog box. And also, you can change the color notation of color strings that were written in the editor by the Convert Color command.

Supported color notations:

See document: https://github.com/anseki/vscode-color

seanonthenet commented 5 years ago

Hi. Thanks for the reply.

Yes, the output notations types are very useful however I would really like the ability to change the selected color using the slider to control the amount of Lightness (instead of Brightness) as an option or a switch (even better).

It's different from HS(B) / HS (V) and is super useful for selecting shades of a color which complement the existing or previous ones.

More info on this is here and also Steve Schoger the UI expert talks about HSL vs HSB a lot. Also Sketch App has also enabled HSL in their color picker.

anseki commented 5 years ago

That feature requires big changing for UI, then I will examine that when more requests come. Thank you again for your comment. :smile: If you want to adjust the lightness now, use the Lab or change the output text as the HSL. (But these have no slider. I know, you want visual UI.)

anseki commented 5 years ago

I close this issue for now. I will examine this feature when more requests come. I still welcome comments.