anselm94 / Torchie-Android

Hold volume buttons to turn on/off torch anytime
https://torchieapp.wordpress.com/
GNU General Public License v2.0
63 stars 26 forks source link

v3.0 build errors on F-Droid #18

Closed relan closed 7 years ago

relan commented 7 years ago

v3.0 fails to build on F-Droid. Steps to reproduce: run gradle assembleRelease.

First issue is that com.android.tools.build:gradle:3.0.0 is available in the new Google Maven repo, not JCenter. Solution: add google() to the repositories sections of the root build.gradle.

Second issue is failing lintVitalRelease task: Error: Non-translatable resources should only be defined in the base values/ folder. Solution: fix those errors or disable them (add checkReleaseBuilds false into build.gradle) or make them non-fatal (add abortOnError false into build.gradle).

anselm94 commented 7 years ago

Hello, Both the issues are fixed now! :)

relan commented 7 years ago

Great! F-Droid will pull the next release automatically when it's out.

anselm94 commented 6 years ago

@relan Can you trigger a rebuild for Torchie at F-Droid? https://f-droid.org/en/packages/in.blogspot.anselmbros.torchie/ doesn't point to latest release

relan commented 6 years ago

Do you mean 3.1? Just tag a release and F-Droid will build it.

anselm94 commented 6 years ago

That's cool! Thanks @relan