search

anselmh / object-fit

Polyfill (mostly IE) for CSS object-fit property to fill-in/fit-in images into containers.
MIT License
996 stars 93 forks source link

No bower as postinstall. #14

Closed kud closed 9 years ago

kud commented 9 years ago

package.json is for npm. It shouldn't contain bower install as postinstall. You should give to dev a /dist version. (and still make it work with bower if you want, yes).

anselmh commented 9 years ago

@kud Why are you so grumpy? Do you think this is helpful? I don’t. So please stop contributing issues this way. It doesn’t help anyone besides maybe yourself. Thanks.

kud commented 9 years ago

It means you won't fix it because of the way I spoke?

kud commented 9 years ago

In fact, I said that because a friend of mine wanted to download your project via npm and he can't use at all because of the postinstall. =(

I was so sad for him.

anselmh commented 9 years ago

No. I just mean you should speak more appropriately to not disappoint people who work hard solving problems for you and provide this for free.

kud commented 9 years ago

Do you want a PR maybe, dear @anselmh. May I give you a suggestion?

anselmh commented 9 years ago

I’m always open for a PR solving issues. And by the way, that’s a great way to contribute. But please bear in mind the package still needs to be fetchable by bower, too. :)

kud commented 9 years ago

Okay lovely @anselmh. Please, accept my apologies for being rude sometimes because of my passion.

Best regards,

anselmh commented 9 years ago

Of course accepted. :)

kud commented 9 years ago

Title + first message edited.

Nyalab commented 9 years ago

hi! see https://github.com/anselmh/object-fit/pull/16

kud commented 9 years ago

By the way, @anselmh if you're interested by package managers in front, read that: http://blog.npmjs.org/post/101775448305/npm-and-front-end-packaging

npm will be more and more better for frontend packages.