search

anselmh / object-fit

Polyfill (mostly IE) for CSS object-fit property to fill-in/fit-in images into containers.
MIT License
996 stars 92 forks source link

remove bower dependance for a npm install #16

Closed Nyalab closed 9 years ago

Nyalab commented 9 years ago

hi! I am working for a front end project without bower, i would like to adapt your project to fit (get it?) to my needs. The bower part should still work, since bower works with bowerrc and bower.json files. Thanks !

kud commented 9 years ago

Did you test if it still works on bower with this solution?

Related to https://github.com/anselmh/object-fit/issues/14

MoOx commented 9 years ago

bower should not use package.json & don't have such pre/post scripts. So should not affect it.

anselmh commented 9 years ago

Thanks! Looks fine at first glance. I’ll have a look at it later.

Nyalab commented 9 years ago

Thanks! Can't wait!

anselmh commented 9 years ago

Thanks again. I merged it and published 0.3.6.

Nyalab commented 9 years ago

Thanks, man.

kud commented 9 years ago

Amazing. Thank you for your support. On 25 Nov 2014 22:30, "Sébastien Balayn" notifications@github.com wrote:

Thanks, man.

— Reply to this email directly or view it on GitHub https://github.com/anselmh/object-fit/pull/16#issuecomment-64474250.

Nyalab commented 9 years ago

Hmmm, did you think to $ npm publish?

anselmh commented 9 years ago

Nope, sorry. Done that now. Bower does automatically fetch tags and I’m used to it now :(

Nyalab commented 9 years ago

No problem! Thanks again.

kud commented 9 years ago

You can do it via npm but it's not the best way.

$ npm install anselmh/object-fit