search

anselmh / object-fit

Polyfill (mostly IE) for CSS object-fit property to fill-in/fit-in images into containers.
MIT License
996 stars 93 forks source link

Skip external css #24

Closed fluke closed 9 years ago

fluke commented 9 years ago

This avoids stylesheets from external domains. Couldn't figure out how to add an option to the initializer. Also added bootstrap through external css to one of the tests so I could test it.

fluke commented 9 years ago

This is for #22

anselmh commented 9 years ago

Thanks man, that’s awesome! Just noted a few minor things to the PR which would be great if you could solve them before I merge this into master. Please let me know when this would be ready to merge. :)

fluke commented 9 years ago

I've split the test I was using into two new files. And I've fixed the issues you pointed. Ready to pull. I haven't implemented the option though.

anselmh commented 9 years ago

Alrighty, that looks great. Would love to have the option though when I merge it as people might want to use ext. stylesheets. Otherwise this change would be major and would need a new major version which I wouldn’t prefer to do. If I find some time, I can jump in for that, too (I’ll just ping you here before then).

anselmh commented 9 years ago

I added the option to the polyfill in 7f0400d265982604f8801763a9e581e0a2ccc49b and merged it in now. Thanks for your help!

fluke commented 9 years ago

Always nice to contribute. Especially when it's something I plan to use.