search

anselmh / object-fit

Polyfill (mostly IE) for CSS object-fit property to fill-in/fit-in images into containers.
MIT License
996 stars 93 forks source link

Alternative fallback #49

Closed mediaformat closed 8 years ago

mediaformat commented 8 years ago

@primozcigler has developped a viable fallback for IE and Edge see here : https://medium.com/@primozcigler/neat-trick-for-css-object-fit-fallback-on-edge-and-other-browsers-afbc53bbb2c3

anselmh commented 8 years ago

Yes, I’ve seen this already, thanks. I’m going to add this as a note into the Readme. But please not this provides only the basic feature of object-fit, and behaves a bit differently so always test if it’s working the way you want it to. :)

anselmh commented 8 years ago

Added to README here.

primozcigler commented 8 years ago

@mediaformat thank you!

As @anselmh mentioned, my fallback explained in article only supports subset of what is possible to achieve with object-fit. But AFAIK the most common use case :smile:

anselmh commented 8 years ago

But AFAIK the most common use case :smile:

It is, so thanks again for building, documenting and publishing this lightweight alternative, @primozcigler! :)

mediaformat commented 8 years ago

This provides only the basic feature of object-fit @anselmh True, I was thinking narrowly of my use case! Thanks for adding the note!

@primozcigler Thank you sir for the clever fallback!