search

anselmh / object-fit

Polyfill (mostly IE) for CSS object-fit property to fill-in/fit-in images into containers.
MIT License
996 stars 92 forks source link

Script goes unresponsive on Bootstrap 3 based site. #8

Closed ok-sure closed 10 years ago

ok-sure commented 10 years ago

It hangs and fails on each image the polyfit is applied to: https://comeround.bbpdev.com/__dev/mph/

anselmh commented 10 years ago

Hi, do you use 0.3.3 already? I currently can only see issue #7 applying to you due to CORS restrictions and cannot re-confirm the performance issue at the moment.

ok-sure commented 10 years ago

Hi - try it now - I am using 0.3.3 btw. Matt

On 27 May 2014 16:10, Anselm Hannemann notifications@github.com wrote:

Hi, do you use 0.3.3 already? I currently can only see issue #7https://github.com/anselmh/object-fit/issues/7applying to you due to CORS restrictions and cannot re-confirm the performance issue at the moment.

— Reply to this email directly or view it on GitHubhttps://github.com/anselmh/object-fit/issues/8#issuecomment-44289288 .

anselmh commented 10 years ago

Thanks, issue is in line 127 of polyfill.object-fit.js. I’ll try to find a solution but also adding @schepp to the loop.

ok-sure commented 10 years ago

Thanks Anselm, appreciate your help. Matt

On 27 May 2014 22:37, Anselm Hannemann notifications@github.com wrote:

Thanks, issue is in line 127 of polyfill.object-fit.js. I’ll try to find a solution but also adding @schepp https://github.com/schepp to the loop.

— Reply to this email directly or view it on GitHubhttps://github.com/anselmh/object-fit/issues/8#issuecomment-44338892 .

ok-sure commented 10 years ago

Any joy on this at all?

On 27 May 2014 22:46, Matt Halliday matt@biffbangpow.com wrote:

Thanks Anselm, appreciate your help. Matt

On 27 May 2014 22:37, Anselm Hannemann notifications@github.com wrote:

Thanks, issue is in line 127 of polyfill.object-fit.js. I’ll try to find a solution but also adding @schepp https://github.com/schepp to the loop.

— Reply to this email directly or view it on GitHub https://github.com/anselmh/object-fit/issues/8#issuecomment-44338892.

anselmh commented 10 years ago

Hey, nope. Hadn’t had much time—only a quick glance—but haven’t found the issue yet. I’m sorry about that and hope to find out soon… :(

anselmh commented 10 years ago

Closing as it’s basically and most likely a duplicate of #13.