search

ansemjo / speedtest-plotter

running scheduled speedtests inside docker and plotting the results with gnuplot
MIT License
59 stars 12 forks source link

terminate called after throwing an instance of 'std::invalid_argument' #168

Closed ansemjo closed 4 months ago

ansemjo commented 5 months ago

There's an issue in the SpeedTest binary used: https://github.com/taganaka/SpeedTest/issues/60

Root cause is that the binary fetches IP address and location information from a deprecated Ookla API, which returns errors and causes the stof (string-to-float) parser to throw an error – which is not caught. There's a pull request, which simply ignores this error in an empty try-catch block.

A proper fix would be to swap the entire endpoint and use a new parser but I'll wait for upstream to hopefully implement something before writing my own patch.

ansemjo commented 4 months ago

Fixed after merging https://github.com/taganaka/SpeedTest/pull/61. Reverted c62033b to build SpeedTest binary from master again.