ansforge / psc-amar-connector

connecteur asynchrone à l'API AMAR
Apache License 2.0
0 stars 0 forks source link

Incoherences in api url property name #24

Open laura-murat opened 2 months ago

laura-murat commented 2 months ago

There appears to be a mismatch between code and properties file with regards to the api url. The application.properties lists the property api.base.url but it never appears to be used in the code. The code refers to a property psc.api.url which does not exist in properties file.

edegenetais-nx commented 2 months ago

@laura-murat : should we close this ?

laura-murat commented 1 month ago

@laura-murat : should we close this ?

As per our discussion, the anomaly has not been resolved, but is outside of our current scope and no bugs have been detected in relation to this. At worst, the property is simply never used.

This issue is mostly here to document the incoherence in case an issue pops up in the future so it should be left open.

edegenetais-nx commented 1 month ago

@laura-murat : should we close this ?

As per our discussion, the anomaly has not been resolved, but is outside of our current scope and no bugs have been detected in relation to this. At worst, the property is simply never used.

This issue is mostly here to document the incoherence in case an issue pops up in the future so it should be left open.

Agreed. Let's keep this open.